Assigning values to objects in a foreach loop

Question

How to assign values to objects in foreach loop. Code is below:

using System;

namespace WorkingWithClasses
{
    class Program
    {
        static void Main(string[] args)
        {
        //create 5 player objects
        Player[] players = new Player[5];
        //assigning a value to a player brings null reference exception error:
        foreach(Player player in players)
        {
            player.Skill = 5;
        }


        float skillSum = 0;
        foreach(Player player in players)
        {
            skillSum += player.Skill;
        }

        Console.WriteLine(skillSum);
    }
}
class Player
{
    public float Skill { get; set; }
}
}

Welcome to Stack Overflow. Unfortunately your question is not clear - it's *just* code apart from the title. Even the comment doesn't say *what* exception you're receiving. I suspect it's a NullReferenceException, in which case you should read https://stackoverflow.com/questions/4660142/what-is-a-nullreferenceexception-and-how-do-i-fix-it. For more guidance on asking a good Stack Overflow question, please read https://codeblog.jonskeet.uk/2010/08/29/writing-the-perfect-question/ — Jon Skeet, Jan 03 '20 at 06:47
What exception error ur getting. Try to assign `5.0F` like that — sri harsha, Jan 03 '20 at 06:50
@sriharsha: There's an implicit conversion from `int` to `float` - that isn't the problem. — Jon Skeet, Jan 03 '20 at 07:02

Ignasi93 · Accepted Answer · 2020-01-03T07:19:14.913

3

Every "Player" in your players array is not initialized. Try with this for loop instead of the foreach loop where you are getting the null reference:

for (var i = 0; i < players.Length; i++)
{
    players[i] = new Player() { Skill = 5 };
}

You can also use this, however it's slower than iterating through the array with a for loop:

using System.Linq;

players = Enumerable.Repeat(new Player() { Skill = 5 }, 5).ToArray();

edited Jan 03 '20 at 07:19

answered Jan 03 '20 at 07:13

Ignasi93

533
2
5
14

Thanks, your answer solved my problem. And yes it was a NullReferenceException. – UnhandledException321 Jan 03 '20 at 16:24

score 0 · Answer 2 · answered Jan 03 '20 at 07:30

0

You need to initialize your players instance object since you are creating array holder.

Replace Player[] players = new Player[5]; with

Player[] players = Enumerable.Repeat(new Player(), 5).ToArray();

answered Jan 03 '20 at 07:30

Turbot

5,095
1
22
30

Assigning values to objects in a foreach loop

2 Answers2