Android GPS location not finding issue. How to correct this code

Question

I am new to android so please forgive me if this very basic error but i am trying it since 3 days but not able to find the solution.

I am just trying to get the user location through gps.

MainActivity.java

import android.Manifest;
import android.content.pm.PackageManager;
import android.location.Location;
import android.os.Looper;
import android.support.annotation.NonNull;
import android.support.v4.app.ActivityCompat;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.view.View;
import android.widget.Button;
import android.widget.TextView;
import android.widget.Toast;
import com.google.android.gms.location.FusedLocationProviderClient;
import com.google.android.gms.location.LocationCallback;
import com.google.android.gms.location.LocationRequest;
import com.google.android.gms.location.LocationResult;
import com.google.android.gms.location.LocationServices;
import com.google.android.gms.tasks.OnSuccessListener;


public class MainActivity extends AppCompatActivity {

//Variables

TextView lat, lng;
Button start, stop;

//Location
private FusedLocationProviderClient fusedLocationProviderClient;
private final static int FINE_LOCATION_REQUEST_CODE = 1000;
LocationRequest locationRequest;
LocationCallback locationCallback;


@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    //initializevar();

    fusedLocationProviderClient = LocationServices.getFusedLocationProviderClient(this);
    lat = (TextView)findViewById(R.id.lat);
    lng = (TextView)findViewById(R.id.lng);

    start = (Button)findViewById(R.id.begin);
    stop = (Button)findViewById(R.id.stop);


    if(ActivityCompat.checkSelfPermission(this,Manifest.permission.ACCESS_FINE_LOCATION)!=PackageManager.PERMISSION_GRANTED) {

        ActivityCompat.requestPermissions(this, new String[]{Manifest.permission.ACCESS_FINE_LOCATION}, FINE_LOCATION_REQUEST_CODE);
        Toast.makeText(this,"Reopen Apps",Toast.LENGTH_LONG);
    }
    else {

        buildlocationrequest();
        buildlocationcallback();

        //create fused provider client
        fusedLocationProviderClient = LocationServices. getFusedLocationProviderClient(this);

        stop.setEnabled(false);


        start.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {

                if (ActivityCompat.checkSelfPermission(MainActivity.this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED
                        && ActivityCompat.checkSelfPermission(MainActivity.this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
                    fusedLocationProviderClient.requestLocationUpdates(locationRequest, locationCallback, Looper.myLooper());
                    return;
                }



                String latt = "Fetching";
                String lngt = "Data";

                lat.setText(latt);
                lng.setText(lngt);

                fusedLocationProviderClient.requestLocationUpdates(locationRequest, locationCallback, Looper.myLooper());

                start.setEnabled(!start.isEnabled());
                stop.setEnabled(!stop.isEnabled());


            }
        });

        stop.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {

                if (ActivityCompat.checkSelfPermission(MainActivity.this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED
                        && ActivityCompat.checkSelfPermission(MainActivity.this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
                    ActivityCompat.requestPermissions(MainActivity.this, new String[]{Manifest.permission.ACCESS_FINE_LOCATION}, FINE_LOCATION_REQUEST_CODE);
                    return;
                }
                fusedLocationProviderClient.removeLocationUpdates(locationCallback);

                start.setEnabled(!start.isEnabled());
                stop.setEnabled(!stop.isEnabled());
            }
        });
    }

}

private void buildlocationcallback() {
    locationCallback = new LocationCallback() {
        @Override
        public void onLocationResult(LocationResult locationResult) {
                for(Location location:locationResult.getLocations())
                {
                    //location mil gaya

                    String latt = "Latitude" + location.getLatitude();
                    String lngt = "Longitude" + location.getLongitude();

                    lat.setText(latt);
                    lng.setText(lngt);

                }
        }
    };
}

private void buildlocationrequest() {

    locationRequest = new LocationRequest();
    locationRequest.setPriority(LocationRequest.PRIORITY_HIGH_ACCURACY);
    locationRequest.setInterval(5000);
    locationRequest.setFastestInterval(3000);
    locationRequest.setSmallestDisplacement(10);
}

@Override
public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
    super.onRequestPermissionsResult(requestCode, permissions, grantResults);
    switch (requestCode)
    {
        case FINE_LOCATION_REQUEST_CODE :
            if(grantResults.length>0)
            {
                if(grantResults[0]==PackageManager.PERMISSION_GRANTED)
                {
                    Toast.makeText(this,"Permission Granted",Toast.LENGTH_LONG).show();
                }
                else if(grantResults[0]==PackageManager.PERMISSION_DENIED)
                {
                    Toast.makeText(this,"Permission Denied You need to enable first",Toast.LENGTH_LONG).show();
                }
            }
    }
}
}

build.gradle

    apply plugin: 'com.android.application'

android {
    compileSdkVersion 27
    defaultConfig {
        applicationId "com.my.gpstracker_myown"
        minSdkVersion 15
        targetSdkVersion 27
        versionCode 1
        versionName "1.0"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    implementation 'com.android.support:appcompat-v7:27.1.1'
    implementation 'com.android.support.constraint:constraint-layout:1.1.3'
    implementation'com.google.android.gms:play-services-location:16.0.0'
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
}

AndroidManifest.xml

<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION"/>

<application
    android:allowBackup="true"
    android:icon="@mipmap/ic_launcher"
    android:label="@string/app_name"
    android:roundIcon="@mipmap/ic_launcher_round"
    android:supportsRtl="true"
    android:theme="@style/AppTheme">
    <activity android:name=".MainActivity">
        <intent-filter>
            <action android:name="android.intent.action.MAIN" />

            <category android:name="android.intent.category.LAUNCHER" />
        </intent-filter>
    </activity>
</application>

I am testing on Real device not emulator and not getting any location updates but on the top location icon appears (which i mean the sign that app is requesting location).

Thanks in Advance

have you add penmission in your Manifest?ACCESS_FINE_LOCATION ACCESS_COARSE_LOCATION — Bogojob, Dec 07 '18 at 19:33
hey ABHAY i'have tested your code on my emulator. I had to do googleservices update but it work fine — Bogojob, Dec 07 '18 at 20:51
I'have tested on my HUAWAi mat not work. I think that you must register your application on google service https://stackoverflow.com/questions/21786797/google-developers-console-how-do-i-register-a-new-application — Bogojob, Dec 07 '18 at 21:00

score 0 · Accepted Answer · answered Dec 07 '18 at 20:39

0

In start.setOnClickListener(new View.OnClickListener() you are checking

(ActivityCompat.checkSelfPermission(MainActivity.this, Manifest.permission.ACCESS_FINE_LOCATION) != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(MainActivity.this, Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) { fusedLocationProviderClient.requestLocationUpdates(locationRequest, locationCallback, Looper.myLooper()); return;

you need to replace the two != by ==

answered Dec 07 '18 at 20:39

j3App

1,510
1
17
26

I am checking if request is not granted then request permission so i think != is correct but still i will try. Thanks – ABHAY NIGAM Dec 08 '18 at 16:14
No, you are checking if permission not granted. And if it is _not_ granted, you call fusedLocationProviderClient.requestLocationUpdates(). In short: you only ask for a location if you do _not_ have a permission to do so. That of course does not make sense, so you need to replace the two != by == – j3App Dec 08 '18 at 17:34
Ohh! I had written wrong in the place of placng request i wanted to write request permission. But still after replacing them still not able to find location. – ABHAY NIGAM Dec 08 '18 at 19:45

Android GPS location not finding issue. How to correct this code

1 Answers1