Merge 2 actions from 2 different controllers in one view - Symfony2

Question

I have the current situation in a Symfony2 website:

• login functionality performed by loginAction in SecurityController. When visiting its route, the action uses parameters ( p1, p2, p3) while rendering the view. (same as FOSUserBundle)

• register functionnality registerAction in RegistrationController is returning a view using other parameters p3,p4,p5. (same as FOSUserBundle)

Parameters are used to hold error messages when form is invalid.

I need to display a homepage that show both functionalities(a form for login and a form for registration), but that can also handle errors due to invalid data.

I can successfuly display the home page(MembersManagementBundle::index.html.twig):

{{ render(controller('MembersManagementBundle:Security:login')) }}

{{ render(controller('MembersManagementBundle:Registration:register')) }}

Controller:

class IndexController extends Controller
{

     public function indexAction()
    {
        return $this->render('MembersManagementBundle::index.html.twig');
    }
}

If good values are entered (whether in login or register form), redirection is performed to the correct target page after form submit.

But,

If bad data is entered to one of the forms, there is a redirection to its specific view with the specific errors( It is normal since submitting form calls the url specified in action attribute which call the corresponding action in corresponding controller).

Questions:

Is is possible to have the two actions in one template with the sum of all parameters? Should I develop indexAction so that it contains the logic of both actions? Or there is another way that can keep the two actions separate but merge the result into indexAction? My goal at the end is to be able to generate index page with the needed errors(p1,p2,p3 or p4,p5,p6).

Thank you. Your help is much appreciated.

Answer 1

This is what your process looks like right now:

1. The User goes to the index page.
2. The Index Page includes 2 forms due calling the render function in twig.
3. The User submits one of the 2 forms.
4. The forms submits and runs through the action that lies behind the form.
5. The form renders only the twig template since that's what the action does in the end.

Now you need to edit it to the following:

1. 1-4 are the same.
2. The form renders the index controller again which will render the 2 forms again. There cannot be a infinity loop since the forms won't be submitted again from the program logic.
3. Now is one point left over: Since the form will action will be run through 2 times, how will the errors be shown? Because they will be set in the first run, but not in the second.

That how you do it:

You add a variable in the loginAction:

$loginErrorsArray = array();

Wherever you'd add a error to the form you add it to the array instead.

//instead of $form->addError(...);
$loginErrorsArray['formField'] = $errorMessage;

Before you're rendering out the form you're saving it into the session.

$this->get('session')->set('loginErrors', $loginErrorsArray);

Now in the same action at the beginning of the code you're getting the session variable and run through it, creating formErrors foreach entry. After that you save a empty array in the session.

$loginErrorsArray = $this->get('session')->get('loginErrors');
foreach($loginErrorsArray as $error){
    $form->addError(...);
}
$this->get('session')->set('loginErrors', array());

Now this will do the following in the action:

1. It gets the array with the errors.
2. Creates errors foreach error found. (since in the first run through there are no errors set there will no be created).
3. Then it will add all errors found to the array.
4. In the second run it will add all errors in the array to the form, but will not create any new to the array.

Hope this is helpfull.