NetworkOnMainThreadException on Facebook Login

Question

I have one activity class and login fragment .there I have used Facebook login.Now Im having exception called.NetworkOnMainThreadException .please find below the code I used.

 package com.maintab;
import org.json.JSONObject;
import com.example.tesfragement.*;
import com.facebook.android.DialogError;
import com.facebook.android.Facebook;
import com.facebook.android.Facebook.DialogListener;
import com.facebook.android.FacebookError;
import com.facebook.android.Util;
import android.os.Bundle;
import android.annotation.SuppressLint;
import android.app.Fragment;
import android.service.textservice.SpellCheckerService.Session;
import android.util.Log;
import android.view.LayoutInflater;
import android.view.View;
import android.view.ViewGroup;
import android.widget.ImageView;
import android.widget.Toast;


@SuppressLint("ValidFragment")
public class Login extends Fragment   {

    View view;
    ImageView loginbuttton,logoutbutton;

    Facebook fb;

    @SuppressLint("ValidFragment")
    public Login(Facebook fb) {

        this.fb=fb;
        // Required empty public constructor
    }

    @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container,
            Bundle savedInstanceState) {
        // Inflate the layout for this fragment
        view= inflater.inflate(R.layout.login, container, false);
        loginbuttton=(ImageView) view.findViewById(R.id.loinbutton);

        thread.start();

        return view;
    }


    Thread thread=new Thread(new Runnable() {

        @Override
        public void run() {
            // TODO Auto-generated method stub

            loginbuttton.setOnClickListener(btnClick);
        }
    });


    ImageView.OnClickListener btnClick=new ImageView.OnClickListener()
    {



        @SuppressWarnings("deprecation")
        @Override
        public void onClick(View v) {
            // TODO Auto-generated method stub


                 if(fb.isSessionValid())
                 {
                     Toast.makeText(getActivity(),"session is valid", Toast.LENGTH_LONG).show();
                 }
                 else{

                        fb.authorize(getActivity(), new String[]{"email"}, new DialogListener() {

                            @Override
                            public void onFacebookError(FacebookError e) {

                                Toast.makeText(getActivity(), "Network Connction Unavaliable", Toast.LENGTH_LONG).show();
                            }

                            @Override
                            public void onError(DialogError e) {
                                // TODO Auto-generated method stub

                            }

                            @Override
                            public void onComplete(Bundle values) {
                                // TODO Auto-generated method stub

                                 try {
                                        JSONObject json = Util.parseJson(fb.request("me"));
                                        String firstName = json.getString("first_name");
                                        String lastName = json.getString("last_name");

                                        String full_name = firstName+" "+lastName;
                                        Log.d("Name", firstName+" "+lastName);

                                        Toast.makeText(getActivity(), "You already have a valid session, " + firstName + " " + lastName + ". No need to re-authorize.", Toast.LENGTH_SHORT).show();
                                        }catch( Exception error ) {
                                            Toast.makeText( getActivity(), error.toString(), Toast.LENGTH_SHORT).show();
                                            }

                            }


                            @Override
                            public void onCancel() {
                                // TODO Auto-generated method stub
                                Toast.makeText(getActivity(), "Login Error...", Toast.LENGTH_LONG).show();
                            }
                        });

                    }




        }

    };
    @Override
    public void onActivityCreated(Bundle savedInstanceState) {
        // TODO Auto-generated method stub
        super.onActivityCreated(savedInstanceState);
    }

}

do your Network related work into Background using AsyncTask — M D, Mar 19 '14 at 04:47

score 1 · Answer 1 · edited May 23 '17 at 11:58

1

do your Network related work into Background using Asynchronous Task.

For more information about Background Handler: http://www.vogella.com/tutorials/AndroidBackgroundProcessing/article.html

and also take a look into this SO Post

edited May 23 '17 at 11:58

Community

1
1

answered Mar 19 '14 at 04:53

M D

47,665
9
93
114

Raghunandan · Answer 2 · 2014-03-19T04:54:52.693

0

You are processing Network operation on the ui thread. Hence the NetworkOnMainThreadException. You could use AsyncTask, Thread or volley.

Also Fragment constructor should have no arguments.

public Login(Facebook fb) { // constructor has an arg

You could follow the facebook login for android docs @

https://developers.facebook.com/docs/android/login-with-facebook/

There is a sample also provided in the facebook sdk i guess.

edited Mar 19 '14 at 04:54

answered Mar 19 '14 at 04:48

Raghunandan

132,755
26
225
256

please find my edited code im getting the same Exception – VenushkaT Mar 19 '14 at 12:36
@VenushkaT simple. follow the docs the link posted in my post – Raghunandan Mar 19 '14 at 12:37
i have followed it but logout button didnt work on me – VenushkaT Mar 19 '14 at 12:41
@VenushkaT then you din't follow it properly. You said login but now you say logout. This exception says that you are running netwrok operation on the main ui thread which is not possible. That should give you a hint to fix it – Raghunandan Mar 19 '14 at 12:43
i ve seen it but to do that i have to go fragement activity.thats the main issue.i have tried it. – VenushkaT Mar 19 '14 at 14:29
@VenushkaT what is the problem navigating to fragment activity?? – Raghunandan Mar 19 '14 at 15:30

score 0 · Answer 3 · answered Mar 19 '14 at 04:50

0

Try this way

Thread thread = new Thread(new Runnable(){
    @Override
    public void run() {
        try {
            //Your code goes here
        } catch (Exception e) {
            e.printStackTrace();
        }
    }
});

thread.start();

answered Mar 19 '14 at 04:50

Kamlesh Arya

4,864
3
21
28

i have done.please find my edited code.still im getting exception.thank you – VenushkaT Mar 19 '14 at 12:38

score 0 · Answer 4 · answered Mar 19 '14 at 05:10

0

Handler myHandler=new Handler(); Runnable runnable;

   new Thread(new Runnable() {

            @Override
            public void run() {
                try {
                    //this is background thread.
                } catch (Exception e) {

                }
                myHandler.post(runnable);
            }
        }).start();
        runnable = new Runnable() {

            @Override
            public void run() {
                //This is UI thread.U can add UI related code here
            }
        };

answered Mar 19 '14 at 05:10

anjaneya

708
9
11

still im getting the same Exception – VenushkaT Mar 19 '14 at 12:36
put this above code in method for example load() and call that method in Oncreate... – anjaneya Mar 19 '14 at 13:00
it didn't work on me.I have tried.can you edit my code.please – VenushkaT Mar 19 '14 at 14:48

NetworkOnMainThreadException on Facebook Login

4 Answers4